-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Increase attachment size options #668
Conversation
aef96c7
to
9b22f03
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not a fan of being so explicit in the allowed array, hardcoding 1 to 20, but I concede that backwards compatibility probably trumps my opinion.
lgtm
'17 MB (e.g. Video files)', | ||
'18 MB (e.g. Video files)', | ||
'19 MB (e.g. Video files)', | ||
'20 MB (e.g. Video files)', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably want to reword these to stop repeating examples - doesn't make much sense UI-wise.
SeventeenMb = '17', | ||
EighteenMb = '18', | ||
NineteenMb = '19', | ||
TwentyMb = '20', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is an enum still the best representation, if we allow every integer in the range? Should we model this differently?
Problem
Closes #662
Solution
Before & After Screenshots
BEFORE:
AFTER:
(email mode)
(storage mode)
Tests
(tested on IE)
.