-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref: migrate stream feedback flow to TypeScript #733
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that I have no clue how to test express streams, and my Google-fu failed me this time. Thus, the success case test is just testing that the services return correctly and not whether the stream passes :(
mantariksh
approved these changes
Nov 26, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR migrates the god controller function for
streamFeedback
into the DDD architecture we all know and love.In addition, also add
AuthService#getFormAfterPermissionChecks
helper function for the repetitive task steps ofThere is also a cherry picked commit 3860e34 from #729 that adds exhaustive switch case typeguard.
Solution
Features:
AuthService#getFormAfterPermissionChecks
helper functionadminFormUtils#getAssertPermissionFn
factory that returns the appropriate function.FeedbackSvc#getFormFeedbackStream
fnAdminFormCtl#handleStreamFormFeedback
handler fnTests
The usual. No success test case for the controller since I still cannot figure out how to handle stream tests, and Google is not helping.
No integration tests yet since router is not migrated yet.