ref: migrate get feedback flow to TypeScript #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also remove now unused code
karrui
force-pushed
the
ref/get-feedback-ts
branch
from
d3dc791 to
fe73da9
Compare
liangyuanruo
approved these changes
Nov 30, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Same old, same old. This PR migrates the god controller function for getFeedback into the DDD architecture we all know and love.
Solution
Features:
AdminFormCtl#handleGetFormFeedbackshandler fnFeedbackSvc#getFormFeedbacksfnImprovements:
getFeedbackcontroller handler and replace withAdminFormCtl#handleGetFormFeedbacksTests
Tests have been written for all new functions.
Note that integration tests are not written yet as the router is not yet migrated.