-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 4.30.0 - acknowledgement for secret key backup, TypeScript migrations #67
Conversation
* chore: update README for banner content precedence * chore: update DEPLOYMENT_SETUP to include new banner env vars
|
|
|
@karrui do you get this weird thing where the page gets squeezed after you click activate? |
@mantariksh Yes. Do you want me to see if I can fix that before release? Might be tricky. |
@karrui imo should fix as it's quite obvious, what do you think? Cannot revert because there's no commit history lol |
I'll try to fix it. Will branch off this release branch. |
ffe607f
to
bf0cca8
Compare
* style: fix width mismatch when storage form is activated * style: fix weird left paddings in activate modal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
spcpCookieDomain: featureManager.props(FeatureNames.SpcpMyInfo) | ||
.spcpCookieDomain, // Cookie domain used for removing spcp cookies | ||
captchaPublicKey: get( | ||
featureManager.props(FeatureNames.Captcha), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would have preferred using typescript's optional operator
captchaPublicKey: featureManager.props(FeatureNames.Captcha)?.captchaPublicKey
But that can be done in a separate PR I guess.
In addition to the changes shown in the files changed, the following changes from the old repo are being released:
New
Improved