Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 4.30.0 - acknowledgement for secret key backup, TypeScript migrations #67

Merged
merged 4 commits into from
Aug 4, 2020

Conversation

mantariksh
Copy link
Contributor

In addition to the changes shown in the files changed, the following changes from the old repo are being released:
Screenshot 2020-08-04 at 12 08 18 PM

New

  • Admins are required to type an acknowledgement that they have saved their secret key before activating their storage mode form.

Improved

  • Error message for form submission failure includes prompt to refresh page.
  • Several backend files migrated to TypeScript.

* chore: update README for banner content precedence

* chore: update DEPLOYMENT_SETUP to include new banner env vars
@mantariksh
Copy link
Contributor Author

mantariksh commented Aug 4, 2020

@mantariksh

  • Create and submit a form with all MyInfo fields.
  • Create a mobile field in a new form. There should be no "SMS Confirmation" toggle
  • Toggle on "Verified" toggle for the mobile field. Go to the public form and attempt to verify your phone number. The OTP should be sent properly to your number. The form should submit correctly.
  • Before release, PROD_BRANCH env var has been set in Travis and restricted to release branch.

Sorry, something went wrong.

@mantariksh
Copy link
Contributor Author

mantariksh commented Aug 4, 2020

@karrui

  • Create a form with a number field. Publish the form and open it in public view. In the admin panel, set the minimum number of characters to 4 and save it. Without refreshing the public form view, key in a single digit and submit. Check that the error message prompts the user to refresh the page.
    ^
    Kar Rui: Does not work, form still can be submitted Works on email mode, I've been testing on storage mode :P

  • Create a form in storage mode. Click on activate form. Check that it is not possible to activate the form without both the secret key and typing the acknowledgement

  • Check that form activation works once you key in the correct secret key and acknowledgement

  • Check that it is not possible to copy the acknowledgement text

  • Check that it is not possible to paste text into the acknowledgement field

  • Check that it is still possible to activate the form with excess whitespace or periods in the acknowledgement input

  • Check that the template for view responses remains unchanged (i.e. only need to upload secret key, no need to type in acknowledgement)

Sorry, something went wrong.

@mantariksh
Copy link
Contributor Author

mantariksh commented Aug 4, 2020

@arshadali172

  • General run through on intranet and IE11.

Sorry, something went wrong.

@mantariksh
Copy link
Contributor Author

@karrui do you get this weird thing where the page gets squeezed after you click activate?
storage ack bug

@karrui
Copy link
Contributor

karrui commented Aug 4, 2020

@mantariksh Yes. Do you want me to see if I can fix that before release? Might be tricky.

@mantariksh
Copy link
Contributor Author

mantariksh commented Aug 4, 2020

@karrui imo should fix as it's quite obvious, what do you think? Cannot revert because there's no commit history lol

@karrui
Copy link
Contributor

karrui commented Aug 4, 2020

@karrui imo should fix as it's quite obvious, what do you think? Cannot revert because there's no commit history lol

I'll try to fix it. Will branch off this release branch.

* style: fix width mismatch when storage form is activated

* style: fix weird left paddings in activate modal
@mantariksh mantariksh requested a review from karrui August 4, 2020 07:27
Copy link
Contributor

@karrui karrui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

spcpCookieDomain: featureManager.props(FeatureNames.SpcpMyInfo)
.spcpCookieDomain, // Cookie domain used for removing spcp cookies
captchaPublicKey: get(
featureManager.props(FeatureNames.Captcha),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would have preferred using typescript's optional operator

captchaPublicKey: featureManager.props(FeatureNames.Captcha)?.captchaPublicKey

But that can be done in a separate PR I guess.

@mantariksh mantariksh merged commit af27b1a into release Aug 4, 2020
@liangyuanruo liangyuanruo deleted the release-4.30.0 branch January 6, 2021 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants