Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: activation modal width change when activation succeeds #69

Merged
merged 2 commits into from
Aug 4, 2020
Merged

fix: activation modal width change when activation succeeds #69

merged 2 commits into from
Aug 4, 2020

Conversation

karrui
Copy link
Contributor

@karrui karrui commented Aug 4, 2020

Problem

Removes the weird width change when storage mode forms successfully activates

Before & After Screenshots

BEFORE:

AFTER:
recording (12)

Also updated the CSS to not have weird left paddings
Screenshot 2020-08-04 at 2 15 58 PM

@karrui karrui requested a review from mantariksh August 4, 2020 06:19
@karrui karrui force-pushed the fix/modal-minimize branch from 0886b6d to a255199 Compare August 4, 2020 06:20
@mantariksh mantariksh merged commit b90be6f into release-4.30.0 Aug 4, 2020
@karrui karrui deleted the fix/modal-minimize branch August 5, 2020 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mantariksh mantariksh mantariksh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karrui @mantariksh