Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: make transfer ownership email more prominent #630

Merged
merged 2 commits into from
Nov 13, 2020
Merged

style: make transfer ownership email more prominent #630

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1708078
style: warning color for email
tshuli Nov 13, 2020
983a9b7
refactor: use class instead of id
tshuli Nov 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/public/modules/core/css/admin-form-header.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,6 +289,10 @@
z-index: 750;
}

#collaborator-modal-body #transfer-owner-email {
color: #dc2a2a;
}

@media all and (min-width: 768px) {
#collaborator-modal-body #bottom-section {
padding-bottom: 30px;
Expand Down
3 changes: 2 additions & 1 deletion src/public/modules/forms/admin/views/collaborator.client.modal.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@
>
<div ng-if="isDisplayTransferOwnerModal">
<div class="label-custom" id="invite-title">
Transfer ownership to {{transferOwnerEmail}}
Transfer ownership to
<span id="transfer-owner-email">{{transferOwnerEmail}}</span>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prefer not using ids and stick to classes. ids can only be used once on the entire layout (and whilst the odds of transfer-owner-email being used somewhere else it's still plausible haha

ids should be kept to maybe a container div/etc, not for a span.

</div>
<div class="" id="collab-title">
Are you sure? You will lose form ownership and the right to delete this
Expand Down