style: make transfer ownership email more prominent #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshuli
changed the title
karrui
approved these changes
Nov 13, 2020
| @@ -10,7 +10,8 @@ | |||
| > | |||
| <div ng-if="isDisplayTransferOwnerModal"> | |||
| <div class="label-custom" id="invite-title"> | |||
| Transfer ownership to {{transferOwnerEmail}} | |||
| Transfer ownership to | |||
| <span id="transfer-owner-email">{{transferOwnerEmail}}</span> | |||
There was a problem hiding this comment.
prefer not using ids and stick to classes. ids can only be used once on the entire layout (and whilst the odds of transfer-owner-email being used somewhere else it's still plausible haha
ids should be kept to maybe a container div/etc, not for a span.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Closes #499
Before & After Screenshots
BEFORE:
AFTER:
Tests