-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove instrumentation for email performance monitoring and SES migration #5766
Conversation
(This PR must be released before we tear down the infra for SES US) |
5e9181b
to
c2a5f1e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
Unless the tracing of the email sending is costing a lot (I assume no right now), let's keep them in for now (traces for email sending + pdf generation), it gives us visibility in processes we are otherwise blind to.
99e4898
to
579c351
Compare
@@ -1,4 +1,4 @@ | |||
import { tracer } from 'dd-trace' | |||
import tracer from 'dd-trace' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this change intended?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops no, but it shouldn't make a difference! it was probably introduced when I reinstated the tracer spans. But it still works, tested on staging + the default import was already used in mail.utils.ts
before
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Problem
We created additional instrumentation over our mailing system in #5019 and #5369 and #5442. This PR tears them down, since they are not needed anymore.
Closes https://github.com/opengovsg/formsg-private/issues/130 and closes https://github.com/opengovsg/formsg-private/issues/132.
Cleaning up old SES config will also close https://github.com/opengovsg/formsg-private/issues/91.
Solution
Delete code that references datadog traces and SES in the US.
Breaking Changes
Tests
Deploy Notes
New environment variables:
for
x
=HOST
,PORT
,USER
,PASS
:SES_{x}
: Should be the value of the old variableSES_{x}_SG
SES_{x}_US
andSES_{x}_SG
: Should be deleted