-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use 2 nodemailer clients #5369
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timotheeg
reviewed
Nov 11, 2022
timotheeg
reviewed
Nov 11, 2022
timotheeg
reviewed
Nov 14, 2022
tshuli
approved these changes
Nov 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, other than Tim's comments and a minor nit
timotheeg
reviewed
Nov 15, 2022
timotheeg
approved these changes
Nov 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Closes #126
Solution
NODEMAILER_THRESHOLD_SG
Breaking Changes
Tests
Deploy Notes
New environment variables:
SES_PORT_US
SES_HOST_US
SES_USER_US
SES_PASS_US
SES_PORT_SG
SES_HOST_SG
SES_USER_SG
SES_PASS_SG
NODEMAILER_SG_WARMUP_START_DATE
: Date to start rollout of emails from SG nodemailer client. Should be in the formatYYYY-MM-DDTHH:MM:SS+08:00
The permissions for the SES sending policy should also be modified accordingly to allow both US and SG nodemailer clients to send emails