-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: merge release 4.43.2 into master #554
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tshuli
commented
Oct 30, 2020
- To merge in only after 4.43.0 and 4.43.1
Bumps [ts-jest](https://github.com/kulshekhar/ts-jest) from 26.3.0 to 26.4.1. - [Release notes](https://github.com/kulshekhar/ts-jest/releases) - [Changelog](https://github.com/kulshekhar/ts-jest/blob/master/CHANGELOG.md) - [Commits](kulshekhar/ts-jest@v26.3.0...v26.4.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Acknowledge the contributions made by TellForm and its lead, as well as those who have worked on FormSG who are not in the commit log Co-authored-by: Antariksh Mahajan <[email protected]>
Bumps [angular-sanitize](https://github.com/angular/angular.js) from 1.8.0 to 1.8.1. - [Release notes](https://github.com/angular/angular.js/releases) - [Changelog](https://github.com/angular/angular.js/blob/master/CHANGELOG.md) - [Commits](angular/angular.js@v1.8.0...v1.8.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
build: merge Release 4.41.0 into develop
Bumps [selectize](https://github.com/selectize/selectize.js) from 0.12.4 to 0.12.6. - [Release notes](https://github.com/selectize/selectize.js/releases) - [Changelog](https://github.com/selectize/selectize.js/blob/master/CHANGELOG.md) - [Commits](selectize/selectize.js@v0.12.4...v0.12.6) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…501) Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 4.0.1 to 4.5.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v4.5.0/packages/parser) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [mongoose](https://github.com/Automattic/mongoose) from 5.10.0 to 5.10.9. - [Release notes](https://github.com/Automattic/mongoose/releases) - [Changelog](https://github.com/Automattic/mongoose/blob/master/History.md) - [Commits](Automattic/mongoose@5.10.0...5.10.9) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This reverts commit 5844618.
Co-authored-by: Yuanruo Liang <[email protected]>
* feat: require non-empty domains if restrict domain is toggled on * style: add red border to edit panel textareas if input is invalid
* feat: log create form failure on GA * feat: add userEmail to log
Bumps [jasmine](https://github.com/jasmine/jasmine-npm) from 3.6.1 to 3.6.2. - [Release notes](https://github.com/jasmine/jasmine-npm/releases) - [Commits](jasmine/jasmine-npm@v3.6.1...v3.6.2) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [ts-node-dev](https://github.com/whitecolor/ts-node-dev) from 1.0.0-pre.49 to 1.0.0. - [Release notes](https://github.com/whitecolor/ts-node-dev/releases) - [Changelog](https://github.com/whitecolor/ts-node-dev/blob/master/CHANGELOG.md) - [Commits](https://github.com/whitecolor/ts-node-dev/commits/v1.0.0) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [twilio](https://github.com/twilio/twilio-node) from 3.49.3 to 3.50.0. - [Release notes](https://github.com/twilio/twilio-node/releases) - [Changelog](https://github.com/twilio/twilio-node/blob/main/CHANGES.md) - [Commits](twilio/twilio-node@3.49.3...3.50.0) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
build: Release 4.42.0 hotfix
build: merge Release 4.42.0 into develop
* chore: allow query params in shared link url * chore: add tests for redirect * feat: implement stealth prefill feature on frontend * chore: relax joi validation for redirect endpoint * chore: address duplicate query param + sanitize * chore: use req.query instead of splitting url * chore(deps): install he * chore: support only unique params * refactor: shift res.redirect to catch block * doc: comment on using $sanitize * chore: add tests * chore: reapply $sanitize * chore: check query.length * chore: add - and _ to test * fix: check for queryParams
Bumps [angular-translate](https://github.com/angular-translate/angular-translate) from 2.18.2 to 2.18.3. - [Release notes](https://github.com/angular-translate/angular-translate/releases) - [Changelog](https://github.com/angular-translate/angular-translate/blob/master/CHANGELOG.md) - [Commits](angular-translate/angular-translate@2.18.2...2.18.3) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* test(BillingRoutes): add some integration tests for GET /billing Missing success scenario * test(BillingRoutes): add success test case * test(BillingRoutes): correct count of forms in comment * test(BillingRoutes): extract helper method to generate login stats
Bumps [eslint](https://github.com/eslint/eslint) from 7.10.0 to 7.12.1. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md) - [Commits](eslint/eslint@v7.10.0...v7.12.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
… + Travis JS heap increase (#533) * fix: local builds failing to transpile due to breaking change in tsnd * chore: increase Javascript heap size available when building in Travis
* feat: tighten isUserInSession conditional for protected routes * feat: add typing for AuthSession * fix: use correct NODE_OPTIONS flag for travis
build: merge Release 4.43.0 to develop
Co-authored-by: Yuanruo Liang <[email protected]>
…disallow prefilling for myinfo fields (#550) * fix(prefill): allow prefill only if scope.field.allowPrefill is true * chore: update form model * doc: add note that unit tests do not cover sanitized fieldvalue * fix(prefill): disallow prefill for myinfo * chore: update typings * refactor: allowPrefill * chore: shift allowPrefill key to shortTextField schema
liangyuanruo
approved these changes
Nov 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.