Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: log create form failure on GA #505

Merged
merged 2 commits into from
Oct 26, 2020
Merged

feat: log create form failure on GA #505

merged 2 commits into from
Oct 26, 2020

Conversation

tshuli
Copy link
Contributor

@tshuli tshuli commented Oct 22, 2020

Problem

Part of #25

Solution

  • Log to GA when admin form creation fails

@tshuli tshuli requested a review from karrui October 22, 2020 05:11
Copy link
Contributor

@karrui karrui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but additional question

gtagService.createFormFailed = () => {
_gtagEvents('create_form', {
event_category: 'Create Form',
event_action: 'Create Form failed',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to log any (or even have any) additional data?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@karrui Thanks! I added user email (perhaps can use for troubleshooting if user gives feedback); apart from that, can't really think of anything else as the form hasn't been created at that point

@tshuli tshuli merged commit 9823124 into develop Oct 26, 2020
@liangyuanruo liangyuanruo deleted the error-alerts branch January 26, 2021 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants