Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Release 4.42.0 #518

Merged
merged 19 commits into from
Oct 27, 2020
Merged

build: Release 4.42.0 #518

merged 19 commits into from
Oct 27, 2020

Conversation

tshuli
Copy link
Contributor

@tshuli tshuli commented Oct 27, 2020 •
edited
Loading

New

  • feat: require non-empty domains if restrict domain is toggled on #507
  • feat: log create form failure on GA #505

Improvements

  • docs(readme): acknowledge TellForm, others #495

Fixes

  • fix: disable restrict email domains toggle if no otp verification #519

Dependency Updates

  • chore: fix node version used to 12.18.4 to be consistent #516
  • chore(deps-dev): bump @typescript-eslint/parser from 4.0.1 to 4.5.0 #501
  • chore(deps-dev): bump jasmine from 3.6.1 to 3.6.2 #508
  • chore(deps-dev): bump ts-jest from 26.3.0 to 26.4.1 #496
  • chore(deps-dev): bump ts-node-dev from 1.0.0-pre.49 to 1.0.0 #510
  • fix(deps): bump angular-sanitize from 1.8.0 to 1.8.1 #494
  • fix(deps): bump mongoose from 5.10.0 to 5.10.9 #449
  • fix(deps): bump selectize from 0.12.4 to 0.12.6 #500
  • fix(deps): bump twilio from 3.49.3 to 3.50.0 #479
  • fix(deps): unpin and bump mongoose from 5.10.0 to 5.10.10 #513

dependabot bot and others added 17 commits October 20, 2020 15:28
@dependabot
chore(deps-dev): bump ts-jest from 26.3.0 to 26.4.1 (#496)
32f4dc0 
Bumps [ts-jest](https://github.com/kulshekhar/ts-jest) from 26.3.0 to 26.4.1.
- [Release notes](https://github.com/kulshekhar/ts-jest/releases)
- [Changelog](https://github.com/kulshekhar/ts-jest/blob/master/CHANGELOG.md)
- [Commits](kulshekhar/ts-jest@v26.3.0...v26.4.1)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@LoneRifle @mantariksh
docs(readme): acknowledge TellForm, others (#495)
8476a17 
Acknowledge the contributions made by TellForm and its lead,
as well as those who have worked on FormSG who are not in
the commit log

Co-authored-by: Antariksh Mahajan <[email protected]>
@dependabot
fix(deps): bump angular-sanitize from 1.8.0 to 1.8.1 (#494)
6c499f4 
Bumps [angular-sanitize](https://github.com/angular/angular.js) from 1.8.0 to 1.8.1.
- [Release notes](https://github.com/angular/angular.js/releases)
- [Changelog](https://github.com/angular/angular.js/blob/master/CHANGELOG.md)
- [Commits](angular/angular.js@v1.8.0...v1.8.1)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@mantariksh
Merge pull request #497 from opengovsg/release-4.41.0
7d62933 
build: merge Release 4.41.0 into develop
@dependabot
fix(deps): bump selectize from 0.12.4 to 0.12.6 (#500)
48f9035 
Bumps [selectize](https://github.com/selectize/selectize.js) from 0.12.4 to 0.12.6.
- [Release notes](https://github.com/selectize/selectize.js/releases)
- [Changelog](https://github.com/selectize/selectize.js/blob/master/CHANGELOG.md)
- [Commits](selectize/selectize.js@v0.12.4...v0.12.6)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump @typescript-eslint/parser from 4.0.1 to 4.5.0 (#…
24e7700 
…501)

Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 4.0.1 to 4.5.0.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/parser/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v4.5.0/packages/parser)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
fix(deps): bump mongoose from 5.10.0 to 5.10.9 (#449)
5844618 
Bumps [mongoose](https://github.com/Automattic/mongoose) from 5.10.0 to 5.10.9.
- [Release notes](https://github.com/Automattic/mongoose/releases)
- [Changelog](https://github.com/Automattic/mongoose/blob/master/History.md)
- [Commits](Automattic/mongoose@5.10.0...5.10.9)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@liangyuanruo
build: revert "fix(deps): bump mongoose from 5.10.0 to 5.10.9"
a6ac8ef 
This reverts commit 5844618.
@liangyuanruo
build: pin mongoose version to 5.10.0 (#504)
4fe70de 
Co-authored-by: Yuanruo Liang <[email protected]>
@karrui
feat: require non-empty domains if restrict domain is toggled on (#507)
1d3213a 
* feat: require non-empty domains if restrict domain is toggled on

* style: add red border to edit panel textareas if input is invalid
@karrui
fix(deps): unpin and bump mongoose from 5.10.0 to 5.10.10 (#513)
5715eac
@tshuli
feat: log create form failure on GA (#505)
9823124 
* feat: log create form failure on GA

* feat: add userEmail to log
@karrui
chore: fix node version used to 12.18.4 to be consistent (#516)
ef537eb
@dependabot
chore(deps-dev): bump jasmine from 3.6.1 to 3.6.2 (#508)
8fc2f24 
Bumps [jasmine](https://github.com/jasmine/jasmine-npm) from 3.6.1 to 3.6.2.
- [Release notes](https://github.com/jasmine/jasmine-npm/releases)
- [Commits](jasmine/jasmine-npm@v3.6.1...v3.6.2)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump ts-node-dev from 1.0.0-pre.49 to 1.0.0 (#510)
ce99ac0 
Bumps [ts-node-dev](https://github.com/whitecolor/ts-node-dev) from 1.0.0-pre.49 to 1.0.0.
- [Release notes](https://github.com/whitecolor/ts-node-dev/releases)
- [Changelog](https://github.com/whitecolor/ts-node-dev/blob/master/CHANGELOG.md)
- [Commits](https://github.com/whitecolor/ts-node-dev/commits/v1.0.0)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
fix(deps): bump twilio from 3.49.3 to 3.50.0 (#479)
455b380 
Bumps [twilio](https://github.com/twilio/twilio-node) from 3.49.3 to 3.50.0.
- [Release notes](https://github.com/twilio/twilio-node/releases)
- [Changelog](https://github.com/twilio/twilio-node/blob/main/CHANGES.md)
- [Commits](twilio/twilio-node@3.49.3...3.50.0)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@tshuli
chore: bump version to v4.42.0
c7edb6e
@tshuli
Copy link
Contributor Author

tshuli commented Oct 27, 2020 •
edited
Loading

feat: require non-empty domains if restrict domain is toggled on
@shuli-ogp

  • Create a form with email field. Turn on restrict domain toggle. Check that it is not possible to save the form with an empty domain list and an error message shows "allowed domains cannot be empty"
  • Fill in a valid restricted domain. Check that the form can now be saved.
  • Check that clicking 'Restrict Email Domains' when 'OTP verification' is toggled false does not lead to field verification failing (i.e. cannot save)

@tshuli
Copy link
Contributor Author

tshuli commented Oct 27, 2020 •
edited
Loading

@karrui
Run through on IE / Intranet
General run through

  • Create email mode form with all fields. Activate and submit form. Check that you can receive responses in your GSIB inbox.

  • Collaborators can be added in email mode.

  • Create storage mode form with all fields. Activate and submit form.

  • Response CSV can be downloaded for storage mode.

  • Responses can be viewed in Data tab in storage mode.

  • Attachments can be downloaded from Data tab in storage mode.

  • Submission IDs can be filtered in storage mode.

  • Collaborators can be added and their collaborating rights edited in storage mode.

  • Flag out any styling errors which you see

  • Create form with MyInfo fields. Submit successfully

    • Unable to access singpass staging on GSIB
    • Singpass staging works on non-GSIB internet laptop using IE

@tshuli
Copy link
Contributor Author

tshuli commented Oct 27, 2020 •
edited by karrui
Loading

@karrui
Run through on IE / Intranet
feat: require non-empty domains if restrict domain is toggled on

  • Create a form with email field. Turn on restrict domain toggle. Check that it is not possible to save the form with an empty domain list and an error message shows "allowed domains cannot be empty"
  • Fill in a valid restricted domain. Check that the form can now be saved.
  • Check that clicking 'Restrict Email Domains' when 'OTP verification' is toggled false does not lead to field verification failing (i.e. cannot save)

karrui
karrui approved these changes Oct 27, 2020
View reviewed changes
Copy link
Contributor

@karrui karrui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

elgeeteeem

@tshuli tshuli merged commit 10084e4 into release Oct 27, 2020
@liangyuanruo liangyuanruo deleted the release-4.42.0 branch January 14, 2021 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karrui karrui karrui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tshuli @karrui @LoneRifle @mantariksh @liangyuanruo