-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(whats-new): update content in What's New #4598
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
already covered by WhatsNewDrawer stories
wanlingt
approved these changes
Aug 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
karrui
added a commit
that referenced
this pull request
Sep 8, 2022
* feat: add last seen feature update date attribute to user collection (#3990) * feat: add last seen feature update date attribute to user collection * feat: add tests * refactor: change type of last seen feature update info attribute to date type Co-authored-by: Siddarth Nandanahosur Suresh <[email protected]> * feat: add new user endpoint to update user last seen feature update date attribute (#3997) * feat: add new user endpoint to update user last seen feature update date attribute * refactor: refactor code and tests * refactor: refactor tests * refactor: refactor code according to comments * refactor: refactor code as per comments Co-authored-by: Siddarth Nandanahosur Suresh <[email protected]> * feat: add views for whats-new feature (#4031) * feat: add views for whats-new feature * refactor: refactor feature update list and use stack for drawer body items * refactor: refactor description for markdown to use template strings * feat: add link copyright text for when feature update list is fully extended * refactor: refactor as per comments * feat: add alt to image Co-authored-by: Siddarth Nandanahosur Suresh <[email protected]> * feat: add new feature update notification logic (#4062) * feat: add new feature update notification logic add notification of new feature update for form admin users add logic to update user last seen feature update date logic * refactor: refactor as per comments * refactor: refactor as per comments Co-authored-by: Siddarth Nandanahosur Suresh <[email protected]> * feat(form-v2/whats-new): add What's new tab on admin nav bar (#4539) * feat: remove button placeholder and add tab on admin nav bar * refactor: fix spelling errors * fix: fix spelling mistake * refactor: remove unnecessary import * refactor: remove unnecessary imports * feat: add notification icon for mobile UI * refactor: refactor code as per comments * refactor: edit UI design styles as per chromatic review comments * refactor: edit font weight for tab label * style(Drawer): update drawer global theme used by What's New feature now, adding parity with Modal styles * feat(What's New): simplify styling * feat: update styling of load more * ref: simplify rendering of drawer Co-authored-by: Siddarth Nandanahosur Suresh <[email protected]> Co-authored-by: Kar Rui <[email protected]> * feat(whats-new): update whats new API to use version flag instead of date flag (#4582) * feat: update whats new API to use version flag instead of date flag * fix: show correct text for extension * feat: move whatsnew activation to admin nav bar button * feat(whats-new): update content in What's New (#4598) * ref: extract LottieAnimation component to templates dir * feat: update what's new feature list to only React content * feat: add presentation role for images in drawer for a11y * feat: remove redundant story already covered by WhatsNewDrawer stories * feat: remove extra line break in whats new content * fix: use whitespace css prop in WhatsNewContent instead Co-authored-by: Siddarth Nandanahosur Suresh <[email protected]> Co-authored-by: Siddarth Nandanahosur Suresh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Only one feature for now (basically React)
Closes #3984