Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(whats-new): update content in What's New #4598

Merged
merged 6 commits into from
Sep 7, 2022

Conversation

karrui
Copy link
Contributor

@karrui karrui commented Aug 17, 2022

Problem

Only one feature for now (basically React)

Closes #3984

@karrui karrui linked an issue Aug 17, 2022 that may be closed by this pull request
8 tasks
@karrui karrui mentioned this pull request Aug 17, 2022
8 tasks
already covered by WhatsNewDrawer stories
@wanlingt wanlingt self-requested a review August 18, 2022 01:58
Copy link
Contributor

@wanlingt wanlingt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@karrui karrui merged commit daf0452 into form-v2/whats-new Sep 7, 2022
@karrui karrui deleted the form-v2/whats-new-update-copy branch September 7, 2022 04:15
karrui added a commit that referenced this pull request Sep 8, 2022
* feat: add last seen feature update date attribute to user collection (#3990)

* feat: add last seen feature update date attribute to user collection

* feat: add tests

* refactor: change type of last seen feature update info attribute to date type

Co-authored-by: Siddarth Nandanahosur Suresh <[email protected]>

* feat: add new user endpoint to update user last seen feature update date attribute (#3997)

* feat: add new user endpoint to update user last seen feature update date attribute

* refactor: refactor code and tests

* refactor: refactor tests

* refactor: refactor code according to comments

* refactor: refactor code as per comments

Co-authored-by: Siddarth Nandanahosur Suresh <[email protected]>

* feat: add views for whats-new feature (#4031)

* feat: add views for whats-new feature

* refactor: refactor feature update list and use stack for drawer body items

* refactor: refactor description for markdown to use template strings

* feat: add link copyright text for when feature update list is fully extended

* refactor: refactor as per comments

* feat: add alt to image

Co-authored-by: Siddarth Nandanahosur Suresh <[email protected]>

* feat: add new feature update notification logic (#4062)

* feat: add new feature update notification logic

add notification of new feature update for form admin users
add logic to update user last seen feature update date logic

* refactor: refactor as per comments

* refactor: refactor as per comments

Co-authored-by: Siddarth Nandanahosur Suresh <[email protected]>

* feat(form-v2/whats-new): add What's new tab on admin nav bar (#4539)

* feat: remove button placeholder and add tab on admin nav bar

* refactor: fix spelling errors

* fix: fix spelling mistake

* refactor: remove unnecessary import

* refactor: remove unnecessary imports

* feat: add notification icon for mobile UI

* refactor: refactor code as per comments

* refactor: edit UI design styles as per chromatic review comments

* refactor: edit font weight for tab label

* style(Drawer): update drawer global theme

used by What's New feature now, adding parity with Modal styles

* feat(What's New): simplify styling

* feat: update styling of load more

* ref: simplify rendering of drawer

Co-authored-by: Siddarth Nandanahosur Suresh <[email protected]>
Co-authored-by: Kar Rui <[email protected]>

* feat(whats-new): update whats new API to use version flag instead of date flag (#4582)

* feat: update whats new API to use version flag instead of date flag

* fix: show correct text for extension

* feat: move whatsnew activation to admin nav bar button

* feat(whats-new): update content in What's New (#4598)

* ref: extract LottieAnimation component to templates dir

* feat: update what's new feature list to only React content

* feat: add presentation role for images in drawer for a11y

* feat: remove redundant story

already covered by WhatsNewDrawer stories

* feat: remove extra line break in whats new content

* fix: use whitespace css prop in WhatsNewContent instead

Co-authored-by: Siddarth Nandanahosur Suresh <[email protected]>
Co-authored-by: Siddarth Nandanahosur Suresh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[React] What's New Feature
2 participants