Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add What's New epic feature #4591

Merged
merged 9 commits into from
Sep 8, 2022
Merged

Conversation

karrui
Copy link
Contributor

@karrui karrui commented Aug 16, 2022

Problem

This PR implements the What's New feature, worked on by @siddarth2824 during his internship.

Closes #3984

Solution

Breaking Changes

  • No - this PR is backwards compatible
    • This epic as a whole is backwards compatible since it is an addition of a flag in the user document.

Features:

Before & After Screenshots

New stories have been added to storybook

Tests

New server-side unit tests have been added for the new update flag endpoint

siddarth2824 and others added 9 commits August 10, 2022 15:39
…3990)

* feat: add last seen feature update date attribute to user collection

* feat: add tests

* refactor: change type of last seen feature update info attribute to date type

Co-authored-by: Siddarth Nandanahosur Suresh <[email protected]>
…ate attribute (#3997)

* feat: add new user endpoint to update user last seen feature update date attribute

* refactor: refactor code and tests

* refactor: refactor tests

* refactor: refactor code according to comments

* refactor: refactor code as per comments

Co-authored-by: Siddarth Nandanahosur Suresh <[email protected]>
* feat: add views for whats-new feature

* refactor: refactor feature update list and use stack for drawer body items

* refactor: refactor description for markdown to use template strings

* feat: add link copyright text for when feature update list is fully extended

* refactor: refactor as per comments

* feat: add alt to image

Co-authored-by: Siddarth Nandanahosur Suresh <[email protected]>
* feat: add new feature update notification logic

add notification of new feature update for form admin users
add logic to update user last seen feature update date logic

* refactor: refactor as per comments

* refactor: refactor as per comments

Co-authored-by: Siddarth Nandanahosur Suresh <[email protected]>
* feat: remove button placeholder and add tab on admin nav bar

* refactor: fix spelling errors

* fix: fix spelling mistake

* refactor: remove unnecessary import

* refactor: remove unnecessary imports

* feat: add notification icon for mobile UI

* refactor: refactor code as per comments

* refactor: edit UI design styles as per chromatic review comments

* refactor: edit font weight for tab label

* style(Drawer): update drawer global theme

used by What's New feature now, adding parity with Modal styles

* feat(What's New): simplify styling

* feat: update styling of load more

* ref: simplify rendering of drawer

Co-authored-by: Siddarth Nandanahosur Suresh <[email protected]>
Co-authored-by: Kar Rui <[email protected]>
…date flag (#4582)

* feat: update whats new API to use version flag instead of date flag

* fix: show correct text for extension

* feat: move whatsnew activation to admin nav bar button
# Conflicts:
#	frontend/src/app/AdminNavBar/AdminNavBar.tsx
* ref: extract LottieAnimation component to templates dir

* feat: update what's new feature list to only React content

* feat: add presentation role for images in drawer for a11y

* feat: remove redundant story

already covered by WhatsNewDrawer stories

* feat: remove extra line break in whats new content

* fix: use whitespace css prop in WhatsNewContent instead
# Conflicts:
#	src/app/modules/user/__tests__/user.controller.spec.ts
@karrui
Copy link
Contributor Author

karrui commented Sep 7, 2022

Will merge in once tests passes, since all its corresponding PRs have been reviewed

FYI @siddarth2824

@karrui karrui marked this pull request as ready for review September 8, 2022 03:56
@karrui karrui merged commit 6bcace4 into form-v2/develop Sep 8, 2022
@karrui karrui deleted the form-v2/whats-new branch September 8, 2022 04:05
@justynoh justynoh mentioned this pull request Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants