feat(form-v2): add MyInfo badge to form builder for MyInfo fields #4538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
MyInfo fields currently are not distinguished from normal fields in the form builder. This PR adds the MyInfo badge to the relevant fields in the form builder.
Closes #4441
Solution
Add an additional base field prop,
showMyInfoBadge(not calledisMyInfobecause we explicitly don't want to show the badge in the public form, only in the form builder).FieldRowContaineradds the badge itself. Also updates to props for Short Text, Dropdown and Date fields to accommodate additional field container props.Breaking Changes
No - this PR is backwards compatible
Screenshots