Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Answers for MyInfo fields in builder should not be editable #4362

Closed
mantariksh opened this issue Jul 26, 2022 · 4 comments
Closed

Answers for MyInfo fields in builder should not be editable #4362

mantariksh opened this issue Jul 26, 2022 · 4 comments
Assignees
@wanlingt
Labels
react-fix-for-qa Must fix before React QA

Comments

@mantariksh
Copy link
Contributor

e.g. "PHUA CHU KANG" for Name should not be editable, to more easily differentiate MyInfo fields from regular fields
@justynoh
Copy link
Contributor

justynoh commented Aug 1, 2022 •
edited
Loading

Also, MyInfo fields in the builder should be labelled as such (#4441 )

image

@justynoh
Copy link
Contributor

justynoh commented Aug 4, 2022

Seems like there was a discussion on this before...

@wanlingt
Copy link
Contributor

Seems like there was a discussion on this before...

discussion has been resolved, refer to the figma discussion link for more details

@wanlingt wanlingt self-assigned this Aug 10, 2022
@wanlingt wanlingt mentioned this issue Aug 12, 2022
Closed
1 task
@mantariksh mantariksh added the react-fix-for-qa Must fix before React QA label Aug 15, 2022
@wanlingt
Copy link
Contributor

wanlingt commented Aug 15, 2022 •
edited
Loading

Closing this issue because we decided to leave myInfo fields in the builder editable. The reason this issue was raised was to easily differentiate MyInfo fields from regular fields, which has been solved by labelling MyInfo fields

@wanlingt wanlingt closed this as not planned Won't fix, can't repro, duplicate, stale Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wanlingt wanlingt

Labels
react-fix-for-qa Must fix before React QA
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@justynoh @mantariksh @wanlingt