-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(storage-responses/2): render individual storage mode form response #4001
Merged
karrui
merged 11 commits into
form-v2/develop
from
form-v2/responses/individual-responses-2
Jul 6, 2022
Merged
feat(storage-responses/2): render individual storage mode form response #4001
karrui
merged 11 commits into
form-v2/develop
from
form-v2/responses/individual-responses-2
Jul 6, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karrui
requested review from
hanstirtaputra,
justynoh,
mantariksh,
siddarth2824,
wanlingt and
tshuli
June 16, 2022 11:15
karrui
force-pushed
the
form-v2/responses/individual-responses-2
branch
from
June 17, 2022 02:47
9c091fd
to
178c403
Compare
karrui
force-pushed
the
form-v2/responses/individual-responses-2
branch
from
June 28, 2022 02:55
178c403
to
e781df9
Compare
timotheeg
approved these changes
Jun 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Base automatically changed from
form-v2/responses/responses-table
to
form-v2/develop
July 6, 2022 08:21
karrui
force-pushed
the
form-v2/responses/individual-responses-2
branch
from
July 6, 2022 08:26
7a9ecb4
to
7e3964e
Compare
1 task
This was referenced Oct 4, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR implements individual storage mode form response feature.
It is available on its own endpoint, meaning form admins can navigate to the individual response if they wanted to.
Some metadata is lost if an individual response is navigated to, such as its respondent index from the table, or the ability to go to the next/previous response.
If navigated via the response table, moving to the next/previous respondent will move the page number of the table backlink accordingly.
Allows for downloading of individual attachment in this view, though not the entire attachments of the individual response (pending design).
Related to #3128
TODO: (will be done in future PRs)
Solution
Features:
IndividualResponsePage
and routeDecryptedRow
component to render responses inside the decrypted submissionBug Fixes:
This PR also contains a bug fix for the bug where the server will reject form submissions due to perceived missing fields due to the change in processing of mobile and email fields in storage mode:
develop
), all mobile and email field answers are sent to the server in storage mode due to the possibility of requiring the data to email users or to verify fields.Before & After Screenshots
TODO: add stories