-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(storage-responses/1): render storage mode responses metadata in table #4000
Conversation
so navigating throughout the form will not reset the secret key once entered
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Btw, sometimes I can only unlock responses in the storybook for "Storage Form Unlocked" when I "open canvas in new tab"
...src/features/admin-form/responses/ResponsesPage/storage/UnlockedResponses/ResponsesTable.tsx
Show resolved
Hide resolved
Yea, that due to stories rerendering multiple times. Suspect it is due to creating a new react-query client on every story. No big deal, we'll get to it when we get to it 😂 Can remount story using the remount icon in the storybook top bar |
...s/admin-form/responses/ResponsesPage/storage/UnlockedResponses/UnlockedResponsesProvider.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
# Conflicts: # frontend/src/mocks/msw/handlers/admin-form/form.ts
No panik at number of lines changed... most come from storybook and msw setup.
edit: wow we are at #4000... i think even the old formsg repo before we open sourced had have this amount... that's awesome.
Problem
This PR implements the table to display metadata of a storage-mode form's responses.
There are also some groundwork done to prepare for navigation of individual responses when clicking into the table row, though that full implementation will come in a later PR.
Closes #3127
Solution
Features:
Improvements:
feat: move StorageResponsesProvider into admin form layout
feat: update app router to use ResponsesLayout for consistent layout inside the responses subroute.
Details ...
Before & After Screenshots
New stories have been added to render unlocked storage mode responses view.