feat(v2): allow creation of rating fields in admin form builder, fix nested updates #3834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
form-v2/adminform/dropdown-builder
to
form-v2/develop
May 6, 2022 10:10
karrui
force-pushed
the
form-v2/adminform/rating-builder
branch
from
0520613 to
dfe0086
Compare
This was referenced Oct 4, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR adds ability to create rating fields in admin form builder screen.
Also fixes bug where nested values were preventing preview from updating. It was most obvious when changing rating field option values, but it also affects changes such as updating validation options for certain fields.
Closes #3403
Solution
Features:
Bug fixes:
Before & After Screenshots
New stories added for EditRating component.