feat(v2): allow creation of dropdown fields in admin form builder #3817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
only used in one place
since those are actually just constants
putting it in __tests__ causes cra's jest to complain T_T
This was referenced May 4, 2022
timotheeg
approved these changes
May 6, 2022
This was referenced Oct 4, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR adds ability to create decimal fields in admin form builder screen.
Also moves
EditFieldDecoratorused by all admin field builder stories into storybook utils to remove duplicate code and some other refactors seen belowCloses #3405
Solution
Features:
Improvements
EditFieldDecoratorinstantiations to storybook utilsBefore & After Screenshots
New stories added for EditDropdown component.