Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: constrain the mongodb objectid regex format and use match #2869

Merged
merged 1 commit into from
Sep 28, 2021
Merged

fix: constrain the mongodb objectid regex format and use match #2869

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/app/modules/spcp/spcp.util.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,9 @@ import {
} from './spcp.types'

const logger = createLoggerWithLabel(module)
const DESTINATION_REGEX = /^\/([\w]+)\/?/

// Matches the MongoDB ObjectID hex format exactly (24 hex characters)
const DESTINATION_REGEX = /^\/([a-fA-F0-9]{24})\/?$/

// Checks the format of a SAML artifact
const isArtifactValid = function (
Expand Down Expand Up @@ -75,7 +77,7 @@ export const isValidAuthenticationQuery = (
* @param destination Redirect destination
*/
export const extractFormId = (destination: string): string | null => {
const regexSplit = DESTINATION_REGEX.exec(destination)
const regexSplit = destination.match(DESTINATION_REGEX)
if (!regexSplit || regexSplit.length < 2) {
return null
}
Expand Down