Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: constrain the mongodb objectid regex format and use match #2869

Merged
merged 1 commit into from
Sep 28, 2021

Conversation

frankchn
Copy link
Contributor

Problem

See #2539, which this closes.

Solution

  1. Applies a more intense regex check to the SPCP return path (making sure that the ObjectID in the path is actually a valid ObjectID)
  2. Use str.match(regex) instead of regex.exec(str) as part of best practices.

Breaking Changes

  • No - this PR is backwards compatible

Tests

Make sure that SPCP login still works.

@frankchn frankchn requested a review from mantariksh September 27, 2021 05:25
Copy link
Contributor

@karrui karrui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@frankchn frankchn merged commit 58bbd44 into develop Sep 28, 2021
@frankchn frankchn deleted the frank/issue-2539 branch September 28, 2021 01:42
@karrui karrui mentioned this pull request Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants