-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(auth.client.service): refactor to Typescript #2132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
better fit API prefix
for mocking localstorage in the frontend jest tests
in preparation for extending from to close #2066
test(UserService): add tests for clearUserFromLocalStorage
…ervice-ts refactor(auth.client): (2) extract verify otp flow to Typescript
refactor(auth.client): (3) extract fetch user service function to Typescript
refactor(auth.client): (4) extract admin logout service function to Typescript
i didn't even touch this part of the code...
refactor(auth.client): (5, final) extract get current logged in user service function to Typescript
# Conflicts: # package.json # src/public/modules/core/components/avatar-dropdown.client.component.js
mantariksh
approved these changes
Jun 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noted the use of truser
in the commits
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR is the base of the feature to prevent merge/rebase hell.
Original chain:
sendOtp
<---verifyOtp
<--fetchUser
<-logout
<--getUserFromLocalStorage
Closes #2057
Solution
Breaking Changes
Features:
Tests
All unit tests for refactored functions have been added as per their individual PRs.
Manual Tests
${params.formTitle} (${params.formId}), ${<your email>}
Deploy Notes
New dependencies:
date-fns
from devDependencies to dependenciesNew dev dependencies:
jest-localstorage-mock
: mock localstorage in frontend jest tests