refactor(beta): migrate to TypeScript #2058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation to porting betas.client.factory to TypeScript, write a suite of unit tests to ensure functionality does not change during the migration. Restructure the AngularJS factory a bit to make code paths easy to reach. - Restructure `betas.client.factory` so that its functions are accessible both via module import and `angular.module().factory()` - Allow the functions to take in other beta feature fields for test purposes, defaulting to `BETA_FEATURES_FIELD` - Provide test coverage via jest, crowbar-ing a mock into the angular global at runtime, to minimise changes to the module under test
LoneRifle
force-pushed
the
refactor/beta/ts
branch
from
698345e to
b87c9be
Compare
liangyuanruo
reviewed
Jun 3, 2021
LoneRifle
force-pushed
the
refactor/beta/ts
branch
from
b87c9be to
6a36203
Compare
LoneRifle
force-pushed
the
refactor/beta/ts
branch
from
6a36203 to
74a2ec8
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Closes #1506
Solution
global at runtime, to minimise changes to the module under test
betas.client.factoryso that its functions areaccessible both via module import and
angular.module().factory()purposes, defaulting to
BETA_FEATURES_FIELD