Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate betas.client.factory.js to TypeScript #1506

Closed
liangyuanruo opened this issue Mar 30, 2021 · 1 comment · Fixed by #2058
Closed

Migrate betas.client.factory.js to TypeScript #1506

liangyuanruo opened this issue Mar 30, 2021 · 1 comment · Fixed by #2058
Assignees
Labels
P2 planned for next 1-2 months

Comments

@liangyuanruo
Copy link
Contributor

liangyuanruo commented Mar 30, 2021

The Betas service is used to manage user access to hidden features in the codebase based on the beta flag permissions within the user object. Originally slated for removal, this has found new use with sgID and should be migrated to TS.

@liangyuanruo liangyuanruo added P2 planned for next 1-2 months discuss to be discussed labels Mar 30, 2021
@liangyuanruo liangyuanruo removed the P2 planned for next 1-2 months label May 10, 2021
@karrui karrui self-assigned this May 12, 2021
@karrui karrui removed their assignment May 12, 2021
@karrui
Copy link
Contributor

karrui commented May 12, 2021

the beta flags are also cleared in the DB and not used anymore so all traces should be safe to remove. I will pick up this issue once it's been assigned a priority @liangyuanruo @syan-syan

@r00dgirl r00dgirl removed the discuss to be discussed label May 27, 2021
@r00dgirl r00dgirl changed the title Delete betas.client.factory.js instead of migrating to TypeScript Migrate betas.client.factory.js to TypeScript May 27, 2021
@r00dgirl r00dgirl added the P2 planned for next 1-2 months label May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 planned for next 1-2 months
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants