-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(webhook-retries): add unit tests for message, producer, consumer (7) #1988
Merged
mantariksh
merged 4 commits into
webhook-retries/main
from
webhook-retries/test-wh-message
Jun 1, 2021
Merged
test(webhook-retries): add unit tests for message, producer, consumer (7) #1988
mantariksh
merged 4 commits into
webhook-retries/main
from
webhook-retries/test-wh-message
Jun 1, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to #1492 |
karrui
approved these changes
Jun 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
||
it('should reject when message body cannot be parsed', async () => { | ||
const result = createWebhookQueueHandler(SUCCESS_PRODUCER)({ | ||
Body: 'yoooooooooooo', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yoooooooooooooooooooooooo
d7af924
to
7e779ee
Compare
mantariksh
added a commit
that referenced
this pull request
Jun 7, 2021
… (7) (#1988) * test: add tests for WebhookQueueMessage * test: add tests for webhook consumer * test: add tests for WebhookProducer * test: add tests for important utils
mantariksh
added a commit
that referenced
this pull request
Jun 8, 2021
* build(webhook-retries): create SQS queue in dev mode (1) (#1938) * feat(webhook-retries): add isRetryEnabled to model (2) (#1939) * feat(webhook-retries): produce and consume retries (3) (#1940) * test(webhook-retries): add unit tests for retrieveWebhookInfoById (5) (#1942) * test(webhook-retries): add unit tests for webhook service (6) (#1943) * test(webhook-retries): add unit tests for message, producer, consumer (7) (#1988) * test: add tests for WebhookQueueMessage * test: add tests for webhook consumer * test: add tests for WebhookProducer * test: add tests for important utils * feat: increase jitter with increasing base interval * fix: calculate next attempt from time of initial attempt * feat(webhook-retries): enable toggling retries on frontend (4) (#1941) * test: make Date.now consistent in producer tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds unit tests for the following:
WebhookQueueMessage
classWebhookProducer
class