Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(webhook-retries): add unit tests for webhook service (6) #1943

Merged
merged 3 commits into from
Jun 1, 2021

Conversation

mantariksh
Copy link
Contributor

@mantariksh mantariksh commented May 20, 2021

  • Cleans up the existing webhook service tests by removing reliance on the model layer
  • Adds tests for the new createInitialWebhookSender function

@mantariksh mantariksh force-pushed the webhook-retries/backend branch from 2ea68bc to 10c8fca Compare May 25, 2021 07:28
@mantariksh mantariksh force-pushed the webhook-retries/test-wh-service branch from 1432323 to 678387f Compare May 25, 2021 07:30
@mantariksh mantariksh marked this pull request as ready for review May 28, 2021 06:32
@karrui
Copy link
Contributor

karrui commented May 31, 2021

Related to #1492

Copy link
Contributor

@karrui karrui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thx for the test cleanup too

@mantariksh mantariksh force-pushed the webhook-retries/test-wh-service branch from ced812d to 523bdd6 Compare June 1, 2021 07:45
@mantariksh mantariksh changed the base branch from webhook-retries/backend to webhook-retries/main June 1, 2021 07:46
@mantariksh mantariksh merged commit 71f6880 into webhook-retries/main Jun 1, 2021
mantariksh added a commit that referenced this pull request Jun 8, 2021
* build(webhook-retries): create SQS queue in dev mode (1) (#1938)

* feat(webhook-retries): add isRetryEnabled to model (2) (#1939)

* feat(webhook-retries): produce and consume retries (3) (#1940)

* test(webhook-retries): add unit tests for retrieveWebhookInfoById (5) (#1942)

* test(webhook-retries): add unit tests for webhook service (6) (#1943)

* test(webhook-retries): add unit tests for message, producer, consumer (7) (#1988)

* test: add tests for WebhookQueueMessage

* test: add tests for webhook consumer

* test: add tests for WebhookProducer

* test: add tests for important utils

* feat: increase jitter with increasing base interval

* fix: calculate next attempt from time of initial attempt

* feat(webhook-retries): enable toggling retries on frontend (4) (#1941)

* test: make Date.now consistent in producer tests
@mantariksh mantariksh deleted the webhook-retries/test-wh-service branch June 8, 2021 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants