refactor: convert rating.client.service.js to typescript enum #1955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mantariksh
suggested changes
May 24, 2021
src/public/modules/forms/admin/controllers/edit-fields-modal.client.controller.js
Outdated
Show resolved
Hide resolved
mantariksh
reviewed
May 24, 2021
mantariksh
approved these changes
May 24, 2021
| @@ -41,6 +42,8 @@ export enum ResponseMode { | |||
| Email = 'email', | |||
| } | |||
|
|
|||
| export const Rating = range(1, 11).map(String) | |||
mantariksh
changed the title
This was referenced May 25, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces
rating.client.service.jswith a new Typescript enumRatingintypes/form.tsand the existingRatingShapeenum intypes/field/ratingField.ts.Closes #1839
Tests