Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert rating.client.service.js into TypeScript enums #1516

Closed
liangyuanruo opened this issue Mar 30, 2021 · 2 comments
Closed

Convert rating.client.service.js into TypeScript enums #1516

liangyuanruo opened this issue Mar 30, 2021 · 2 comments
Labels
discuss to be discussed easy possible issues that beginners can pick up to get acquainted with the codebase P2 planned for next 1-2 months

Comments

@liangyuanruo
Copy link
Contributor

This service encodes the steps and shape of the rating field. It should be straightforward to convert to an enum, but do also perform a check to ensure that the DRY principle is followed and that any new data created is consistent with existing backend definitions.
@liangyuanruo liangyuanruo added P2 planned for next 1-2 months easy possible issues that beginners can pick up to get acquainted with the codebase labels Mar 30, 2021
@karrui
Copy link
Contributor

karrui commented May 12, 2021

Similar to #1503, this may not actually need to be migrated

@karrui karrui added the discuss to be discussed label May 12, 2021
@mantariksh
Copy link
Contributor

Closed via #1955

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discuss to be discussed easy possible issues that beginners can pick up to get acquainted with the codebase P2 planned for next 1-2 months
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@liangyuanruo @karrui @mantariksh