-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use neverthrow in /:transactionId/otp/verify (part 6) #1455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mantariksh
force-pushed
the
vfn-neverthrow/verify-otp
branch
from
March 25, 2021 04:24
a799093
to
dfbe29a
Compare
mantariksh
force-pushed
the
vfn-neverthrow/verify-otp
branch
from
March 26, 2021 10:39
0a600b2
to
a0c7b2b
Compare
mantariksh
force-pushed
the
vfn-neverthrow/send-otp
branch
from
March 26, 2021 10:58
17bda3e
to
c539a8e
Compare
mantariksh
force-pushed
the
vfn-neverthrow/verify-otp
branch
from
March 26, 2021 11:03
a0c7b2b
to
a5f2391
Compare
mantariksh
force-pushed
the
vfn-neverthrow/send-otp
branch
from
March 29, 2021 03:19
c539a8e
to
333c77a
Compare
mantariksh
force-pushed
the
vfn-neverthrow/verify-otp
branch
from
March 29, 2021 03:19
a5f2391
to
65534a5
Compare
mantariksh
force-pushed
the
vfn-neverthrow/send-otp
branch
from
March 29, 2021 08:02
333c77a
to
3384ec0
Compare
mantariksh
force-pushed
the
vfn-neverthrow/verify-otp
branch
from
March 29, 2021 08:03
65534a5
to
c1fe909
Compare
This was referenced Mar 30, 2021
mantariksh
force-pushed
the
vfn-neverthrow/send-otp
branch
2 times, most recently
from
March 30, 2021 02:18
0c41ca8
to
9036277
Compare
TODO from previous PRs
|
mantariksh
force-pushed
the
vfn-neverthrow/verify-otp
branch
from
March 30, 2021 05:11
c1fe909
to
c8f8907
Compare
karrui
approved these changes
Mar 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
mantariksh
force-pushed
the
vfn-neverthrow/verify-otp
branch
from
March 30, 2021 08:37
c8f8907
to
55042bf
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #1454
Problem
See #1450
Solution
This is the 6th part of the solution, which focuses on the
POST /transaction/:transactionId/otp/verify
endpoint. It includes the following additional improvements:verification.(controller|service).spec.ts
and replaces them withverification.(controller|service).new.spec.ts
For reviewers
Note that in
verification.service.spec.ts
andverification.controller.spec.ts
, the only new tests added were forverifyOtp
andhandleVerifyOtp
respectively. The rest of the changes are due to the file renaming.Tests
See #1450