Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert verification service to use neverthrow #941

Closed
liangyuanruo opened this issue Dec 24, 2020 · 2 comments
Closed

Convert verification service to use neverthrow #941

liangyuanruo opened this issue Dec 24, 2020 · 2 comments
Assignees
@mantariksh
Labels
discuss to be discussed P2 planned for next 1-2 months

Comments

@liangyuanruo
Copy link
Contributor

liangyuanruo commented Dec 24, 2020 •
edited
Loading

The verification service was one of the earlier services to be converted to TypeScript, before the team took the decision to use the neverthrow library and avoid throwing exceptions.

TODO: convert the implementation to use said package, and re-examine the type assertions made.

Blocked by opengovsg/formsg-javascript-sdk#45
@liangyuanruo liangyuanruo added the P2 planned for next 1-2 months label Dec 24, 2020
@liangyuanruo liangyuanruo mentioned this issue Dec 27, 2020
Merged
@mantariksh mantariksh mentioned this issue Jan 4, 2021
Merged
4 tasks
@mantariksh
Copy link
Contributor

TODO: make SmsFactory interface consistent by using Promise.reject when Sms feature is not enabled

@liangyuanruo liangyuanruo mentioned this issue Jan 19, 2021
Closed
@r00dgirl r00dgirl added the discuss to be discussed label Mar 10, 2021
@mantariksh mantariksh mentioned this issue Mar 22, 2021
Merged
@mantariksh
Copy link
Contributor

Closed via #1455

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mantariksh mantariksh

Labels
discuss to be discussed P2 planned for next 1-2 months
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@liangyuanruo @mantariksh @r00dgirl