Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verification module is undefined if the signing secret key is not provided #45

Closed
liangyuanruo opened this issue Jan 19, 2021 · 2 comments
Assignees
Labels

Comments

@liangyuanruo
Copy link
Contributor

The runtime SDK has the strange behavior where the verification module is missing if the signing secret key isn’t provided.

Initially thought to be a smart way to protect the SDK user, this design actually causes the need for type coercion in the verification service within the main Forms codebase (see opengovsg/FormSG#941).

Change the behavior of the SDK to throw an exception instead.

@frankchn
Copy link
Contributor

@karrui
Copy link
Contributor

karrui commented Feb 18, 2021

Yes, this should have been fixed in #38. This is just not pushed to npm yet

@karrui karrui closed this as completed Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants