Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow adding additional assets #230

Merged
merged 2 commits into from
Aug 18, 2023
Merged

Allow adding additional assets #230

merged 2 commits into from
Aug 18, 2023

Conversation

m-kuhn
Copy link
Member

@m-kuhn m-kuhn commented Jun 17, 2023

Adds a new parameter --asset-path or -a followed by a path to an additional asset to be packaged/released.

qgis-plugin-ci package 1.0 --asset-path myplugin/some_dependency-1.0-py3-none-any.whl

Adds a new parameter `--asset-path` or `-a` followed by a path to an additional asset to be packaged/released.

```
qgis-plugin-ci package 1.0 --asset-path myplugin/some_dependency-1.0-py3-none-any.whl
```
@m-kuhn
Copy link
Member Author

m-kuhn commented Jun 17, 2023

I am a bit lost with the super long error log, the only error I found is about uncommitted changes which I don't see why that would happen.

@3nids 3nids closed this Jun 19, 2023
@3nids 3nids reopened this Jun 19, 2023
Copy link
Collaborator

@suricactus suricactus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. What do we need to get this merged?

@m-kuhn
Copy link
Member Author

m-kuhn commented Aug 3, 2023

It looks like other recent pull requests have the same error, so unrelated to this code.

@3nids @Gustry ? (pinging some random people :-) )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants