Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libs Folder in Plugin-Ci #750

Closed
signedav opened this issue Nov 7, 2022 · 4 comments
Closed

Libs Folder in Plugin-Ci #750

signedav opened this issue Nov 7, 2022 · 4 comments
Labels
dev_stuff code structure etc. used by the devs

Comments

@signedav
Copy link
Member

signedav commented Nov 7, 2022

Currently the libs folder is not added to the released plugin. At the moment, I need to do it manually.

Add this step in release in continous_intergration.yml

      - name: Package PyPI Packages
        run: |
          sudo ./scripts/package_pip_packages.sh

But the plugin ci needs to allow libs folder because otherwise the libs folder is missing.

@signedav signedav added the dev_stuff code structure etc. used by the devs label Nov 7, 2022
@3nids
Copy link
Member

3nids commented Nov 1, 2023

At the moment qgis-plugin-ci works on a git architecture using git archive and supports submodules.

I'm not even sure how your current workflow works since it seems the libs folder is never committed?

How would you expect this to work? By specifying depedencies to be added in .qgis-plugin-ci.yaml ?

@signedav
Copy link
Member Author

signedav commented Nov 1, 2023

Naively I though it's possible to run ./scripts/package_pip_packages.sh on packaging.

But if a libs folder is needed on this repo I could run it on a merge to master action as well...

@signedav
Copy link
Member Author

signedav commented Nov 2, 2023

But if a libs folder is needed on this repo I could run it on a merge to master action as well...

Is this the way to go @3nids in your opinion?

@3nids
Copy link
Member

3nids commented Nov 2, 2023

Basically, I see 2 approaches:

  1. you can just git add & commit your lib folder just before running plugin_ci
  2. use what Matthias did here: Allow adding additional assets qgis-plugin-ci#230

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev_stuff code structure etc. used by the devs
Projects
None yet
Development

No branches or pull requests

2 participants