[Split Checkout] Recalculate tax on summary step #9631
Conversation
And reduce code by referring to objects instead of just ids.
Somehow the helper methods were testing two different orders even though each spec is using only one order, the one which is currently being checked out by the user. So I brought the code closer into the example to easier see what is related and tested. I also changed the assertions for the pending spec but can't really verify them yet until I have completely working code.
It reduced the execution time by 5% on my machine (2-3 seconds).
mkllnk
force-pushed
the
9153-tax-recalculation
branch
from
e50b1ad to
1d04510
Compare
|
Hi @mkllnk, Before this PRMy understanding is that before this PR:
I was able to confirm this before staging this PR. Nunavut (no taxes), legacy checkout: Ontario (taxes), legacy checkout: Nunavut (no taxes), split checkout: Ontario (taxes), split checkout: After this PRSplit checkout: Taxes applied to products and shipping (shipping address inside tax zone and shipping method with tax) Legacy checkout: Taxes applied to products and shipping (shipping address inside tax zone and shipping method with tax) Split checkout: Taxes applied to products, but not to shipping (shipping address inside tax zone but shipping method without tax): Legacy checkout: Taxes applied to products, but not to shipping (shipping address inside tax zone but shipping method without tax): Split checkout: No taxes applied (shipping address outside tax zone): Legacy checkout: No taxes applied (shipping address outside tax zone): Results
It's looking good. Moving to Ready to Go! 🚀 |
|
Hold on! Moving back to Test Ready... |
|
Ok, I was wondering about this, but we have that in master as well... |
What? Why?
What should we test?
Release notes
Changelog Category: User facing changes
The title of the pull request will be included in the release notes.
Dependencies
Documentation updates