-
-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split Checkout: add error message when no shipping methods are available to the customer #9536
Conversation
a8b811b
to
cf0bd39
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good but needs a conflict resolution. Moving to dev.
cf0bd39
to
f0f2872
Compare
Hi @jibees, Before this PRI have first tested before staging your PR to reproduce the issue. You can see the useless error message in the screen capture below. All shipping methods are set to backoffice onlySplit checkout: Shipping method is hidden through tag rules:Split checkout: Shipping method is shown through tag rules:Split checkout: After this PRAll shipping methods are set to backoffice onlyLegacy checkout: Shipping method is hidden through tag rules:Legacy checkout: Shipping method is shown through tag rules:Split checkout: Legacy checkout: I have nothing else to ask for. This one is ready to go! 🎆 |
f0f2872
to
d878d91
Compare
I resolved a conflict and will merge once specs pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like we have a related spec failure now. Back to In Dev.
Seems to be unrelated to this branch, as it also occurs in master: https://github.com/openfoodfoundation/openfoodnetwork/runs/8240457288?check_suite_focus=true Since, merging #9631 I'll open an issue, and try to resolve it. |
This is probably good to go then? |
d878d91
to
86cb86e
Compare
What? Why?
Closes #9145
This adds a flash error message when no available shippings methods:
What should we test?
No shipping methods can occurs either:
Release notes
Changelog Category: User facing changes