Sets js_errors to false #8357
Merged
Sets js_errors to false #8357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If it means getting back a green build now and working on js_errors in a separate PR, it's just wonderful! ❤️ |
jibees
approved these changes
Oct 14, 2021
Sets js_errors to false Sets headless to true
filipefurtad0
force-pushed
the
remove_js_errors_on_system
branch
from
7e1655c to
ef68791
Compare
mkllnk
approved these changes
Oct 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Relates to #8356
I could not fix the specs which are the underlying cause for this, as described on the issue above, which remains open so we can address this seperatedly. This PR should turn the build back to green.
Setting
js_errorsto false should temporarily hide these errors which are breaking the build.What should we test?
Green build.
Release notes
Sets
js_errorsto false oncuprite_setup.rbChangelog Category: Technical changes