JS errors on system specs (red build)

[filipefurtad0]

What we should change and why (this is tech debt)

The build is broken, due to JS errors on system specs:

rspec ./spec/system/consumer/account/payments_spec.rb:24 # Payments requiring action as a logged in user there is a payment requiring authorization shows a table of payments requiring authorization
rspec ./spec/system/consumer/account/payments_spec.rb:37 # Payments requiring action as a logged in user there are no payments requiring authorization does not show the table of payments requiring authorization
rspec ./spec/system/consumer/account/settings_spec.rb:25 # Account Settings as a logged in user allows the user to update their email address
rspec ./spec/system/consumer/account/settings_spec.rb:45 # Account Settings as a logged in user allows the user to change their password

Context

Since PR #8310 we can check for JS errors on system specs.

Impact and timeline

[mkllnk]

It's an order dependent fail:

rspec ./spec/system/consumer/account/cards_spec.rb[1:1:1] ./spec/system/consumer/account/payments_spec.rb[1:1:1:1]

By the way, I found this by using Rspec's bisect feature:

bundle exec rspec --seed 0 --bisect -- spec/system
...
Bisect complete! Reduced necessary non-failing examples from 121 to 26 in 1076 minutes 24 seconds.

The minimal reproduction command is:
  rspec ./spec/system/admin/customers_spec.rb[1:1:1:2:1:1,1:1:1:2:2:1,1:1:1:4,1:1:1:5:1,1:1:1:5:2] ./spec/system/consumer/account/cards_spec.rb[1:1:1] ./spec/system/consumer/account/payments_spec.rb[1:1:1:1] ./spec/system/consumer/account/settings_spec.rb[1:1:1,1:1:2] ./spec/system/consumer/shopping/checkout_spec.rb[1:2:1:3,1:2:3:1,1:2:4:1,1:3:5:1,1:3:9:2:3:1,1:3:9:2:5:1:1,1:3:9:2:5:1:2,1:3:9:2:5:2:1,1:3:9:2:5:2:2] ./spec/system/consumer/shopping/embedded_shopfronts_spec.rb[1:1:2,1:1:3] ./spec/system/consumer/shopping/orders_spec.rb[1:1:3:1,1:2:2:1,1:2:3:1] ./spec/system/consumer/shopping/shopping_spec.rb[1:1:3:1:1,1:1:3:1:2:1,1:1:4:1,1:1:4:2] ./spec/system/consumer/user_password_spec.rb[1:1:1,1:2:4] --seed 0 --

That's not quite minimal though. You can see above that it's jut the cards_spec that messes things up.

[filipefurtad0]

Thank you for sharing that knowledge @mkllnk - that's very appreciated ❤️