Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Bogus" payment providers from staging and production #6809

Merged

Conversation

andrewpbrett
Copy link
Contributor

What? Why?

Closes #5093

The payment methods were made translatable in #6540. This removes the Bogus and BogusSimple providers in production since we can't use them there.

What should we test?

On a staging server, logged in as an admin, the Bogus/Bogus Simple providers should not appear in the list of payment providers when creating a new payment method or editing an existing one.

Release notes

Removed the Bogus and BogusSimple payment providers from the list of providers.

Changelog Category: User facing changes

Dependencies

Documentation updates

Copy link
Contributor

@sauloperez sauloperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good trick 👏 I'd create an issue to better solve this though. It's fine if we don't want to touch any records referencing these gateways but we should fetch from DB only the ones we support, without any per-environment conditional.

@filipefurtad0 filipefurtad0 self-assigned this Feb 4, 2021
@filipefurtad0 filipefurtad0 added the pr-staged-uk staging.openfoodnetwork.org.uk label Feb 4, 2021
@filipefurtad0
Copy link
Contributor

filipefurtad0 commented Feb 4, 2021

Hey @andrewpbrett

Before this PR:
image

After:
image

Bogus payment methods are now gone 👍

I see the the other providers were translated already (pic from production):

image

This is good to go.

@filipefurtad0 filipefurtad0 removed the pr-staged-uk staging.openfoodnetwork.org.uk label Feb 4, 2021
@sauloperez sauloperez merged commit 4b892d4 into openfoodfoundation:master Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean payment method provider list (and maybe translate it?)
3 participants