Add internationalization to payment method clean name

[PauloVilarinho]

What? Why?

Closes #6535

This adds internationalization to the payment method model clean name method, fixing the internationalzation of the new payment method at the admin panel

What should we test?

Test create new payment method at admin panel

Release notes

Internationalization added at creating new payment method at admin panel for the payment method type

Changelog Category: User facing changes

[Matt-Yorkley]

LGTM, thanks @PauloVilarinho ❤️

[andrewpbrett]

Thanks @PauloVilarinho !

[andrewpbrett]

@PauloVilarinho I moved this to the Test Ready column on our ZenHub. It may be a little while before it gets merged and deployed since not as many people are around in the next couple weeks, but it'll get in there soon! And we can take a look at the other PR you sent in the meantime. Thanks again! 🎉

[filipefurtad0]

Olá @PauloVilarinho ,
Welcome!

Thanks for fixing this. I see you added the keys for this in en.yml, the page renders correctly, so all should work once the translations are updated on Transifex:

The arrow above spots another missing translation - unrelated to this PR.

Looks good, moving to ready to go!
Thank you 🎉

[RachL]

@Matt-Yorkley @andrewpbrett I see this has been included in the release deployed on Tuesday yet I don't see the strings in Transifex. Can you confirm which strings I should be looking for?

[sigmundpetersen]

I see the auto update of en.yml on Transifex has been turned off since Dec 9th.
I guess this is done while we're trying to find the best process for translation between releases.
But it means there has not been pushed any strings to Transifex since that date ⚠️

[andrewpbrett]

Ohhh good catch @sigmundpetersen. I was just opening transifex to check the keys; see also this discussion: #6508 (comment)

[sauloperez]

would you mind turning it on meanwhile @sigmundpetersen ?

[andrewpbrett]

Is there an admin login to Transifex? I don't see the button to turn the updating back on, and I don't see an admin login in bitwarden. Or maybe someone could make me an admin in Transifex :)

[sigmundpetersen]

I added back the url, will wait and see if it updates.
I added you as admin on Transifex @andrewpbrett , you should see the button now 🙂

[sigmundpetersen]

the check happens 4 times a day

I guess we will have to wait a while 🙈
Or we can push an update with the command line client
https://docs.transifex.com/projects/updating-content/

[andrewpbrett]

Okay I just ran tx push -s with the latest master and I see the string spree.admin.payment_methods.providers.stripesca, for example, in Transifex.

[RachL]

Along with 24 other new strings 😅 yay! Thanks guys