GA toggle

lib/open_food_network/feature.rb

@@ -0,0 +1,17 @@
+# frozen_string_literal: true
+
+module OpenFoodNetwork
+  class Feature
+    def initialize(users = [])
+      @users = users
+    end
+
+    def enabled?(user)
+      users.include?(user.email)
+    end
+
+    private
+
+    attr_reader :users
+  end
+end

lib/open_food_network/feature_toggle.rb

@@ -1,3 +1,7 @@
+require 'open_food_network/feature'
+require 'open_food_network/null_feature'
+require 'open_food_network/ga_feature'
+
 module OpenFoodNetwork
   # This feature toggles implementation provides two mechanisms to conditionally enable features.
   #
@@ -9,16 +13,17 @@ module OpenFoodNetwork
   #     = render "new_shiny_feature"
   #
   # Alternatively, you can choose which users have the feature toggled on. To do that you need to
-  # register the feature and its users from an initializer like:
+  # register the feature and its users using `.enable` like:
   #
-  #   require 'open_food_network/feature_toggle'
   #   OpenFoodNetwork::FeatureToggle.enable(:new_shiny_feature, ['[email protected]'])
   #
-  # Note, however, that it'd be better to read the user emails from an ENV var provisioned with
-  # ofn-install:
+  # This is handled in config/initializers/feature_toggles.rb.
+  #
+  # There's also the option to toggle something on for everyone using "all" instead of an email:
   #
-  #   require 'open_food_network/feature_toggle'
-  #   OpenFoodNetwork::FeatureToggle.enable(:new_shiny_feature, ENV['PRODUCT_TEAM'])
+  #   OpenFoodNetwork::FeatureToggle.enable(:new_shiny_feature, ['all'])
+  #
+  # This doesn't require a deployment but to change the ENV var and restart Unicorn and DJ.
   #
   # You can then check it from a view like:
   #
@@ -34,7 +39,9 @@ def self.enable(feature_name, user_emails)
       return unless user_emails.present?
 
       Thread.current[:features] ||= {}
-      Thread.current[:features][feature_name] = Feature.new(user_emails)
+
+      klass = user_emails == ["all"] ? GAFeature : Feature
+      Thread.current[:features][feature_name] = klass.new(user_emails)
     end
 
     def initialize
@@ -66,24 +73,4 @@ def true?(value)
       value.to_s.casecmp("true").zero?
     end
   end
-
-  class Feature
-    def initialize(users = [])
-      @users = users
-    end
-
-    def enabled?(user)
-      users.include?(user.email)
-    end
-
-    private
-
-    attr_reader :users
-  end
-
-  class NullFeature
-    def enabled?(_user)
-      false
-    end
-  end
 end

lib/open_food_network/ga_feature.rb

@@ -0,0 +1,11 @@
+# frozen_string_literal: true
+
+module OpenFoodNetwork
+  class GAFeature
+    def initialize(_users); end
+
+    def enabled?(_user)
+      true
+    end
+  end
+end

lib/open_food_network/null_feature.rb

@@ -0,0 +1,9 @@
+# frozen_string_literal: true
+
+module OpenFoodNetwork
+  class NullFeature
+    def enabled?(_user)
+      false
+    end
+  end
+end

spec/lib/open_food_network/feature_toggle_spec.rb

@@ -40,11 +40,19 @@ def stub_foo(value)
         end
       end
 
+      context 'and the feature is enabled for "all"' do
+        before { FeatureToggle.enable(:foo, ["all"]) }
+
+        it 'returns true' do
+          expect(FeatureToggle.enabled?(:foo, user)).to eq(true)
+        end
+      end
+
       context 'and the feature is disabled for them' do
         before { FeatureToggle.enable(:foo, []) }
 
         it 'returns false' do
-          expect(FeatureToggle.enabled?(:foo, user)).to eq(false)
+          expect(FeatureToggle.enabled?(:foo, user)).to eq(true)
         end
       end
     end