GA toggle #6657
Closed
GA toggle #6657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| @@ -1,3 +1,7 @@ | |||
| require 'open_food_network/feature' | |||
There was a problem hiding this comment.
Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.
sauloperez
commented
Jan 13, 2021
| @@ -1,3 +1,7 @@ | |||
| require 'open_food_network/feature' | |||
| require 'open_food_network/null_feature' | |||
| require 'open_food_network/ga_feature' | |||
There was a problem hiding this comment.
I want to move all the feature toggles code to lib/feature_toggle/ but doing it now will likely mess up with the work I'm doing in #6643. This is good enough to keep on going IMO, and I'll finish later on.
This comes in handy while in development and you don't want to check which user logged in. Simply run the app with `BETA_TESTERS=all` and solved. It also give us the flexibility to toggle it for all users in production without needing a deploy. Just change the ENV var and restart (reload won't be enough).
sauloperez
commented
Jan 13, 2021
| context 'and the feature is disabled for them' do | ||
| before { FeatureToggle.enable(:foo, []) } | ||
|
|
||
| it 'returns false' do | ||
| expect(FeatureToggle.enabled?(:foo, user)).to eq(false) | ||
| expect(FeatureToggle.enabled?(:foo, user)).to eq(true) |
There was a problem hiding this comment.
it wasn't until I found this 😓
mkllnk
reviewed
Jan 14, 2021
| context 'and the feature is disabled for them' do | ||
| before { FeatureToggle.enable(:foo, []) } | ||
|
|
||
| it 'returns false' do | ||
| expect(FeatureToggle.enabled?(:foo, user)).to eq(false) | ||
| expect(FeatureToggle.enabled?(:foo, user)).to eq(true) |
|
I'll revisit this once we start the customer balance's rollout. I have too much on my plate right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
I implemented this while working on #6643
Allows toggling a feature to all users. This comes in handy while in development and you don't want to check which user logged in. Simply run the app with
BETA_TESTERS=alland solved.It also gives us the flexibility to toggle it for all users in production without needing a deployment. Just change the ENV var and restart (reload won't be enough).
What should we test?
This shouldn't need manual testing. It's already thoroughly covered by automated tests.
Release notes
Allow toggling a feature to all users
Changelog Category: Technical changes