[Bye bye spree] Bring Spree engine.rb from spree core #5929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisramos0
force-pushed
the
spree_core_engine
branch
from
4bf7960 to
78ece5e
Compare
|
this is now in #5978 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring engine-rb from spree_core, the core of the core, almost last step.
core/lib/spree/core/engine.rb COPY most of it.
Build is broken with a problem with a dependency to Spree::Preferences::Preferable in engine.rb
We can wait for #5870 where preferable is brought from spree_core, or we can leave engine.rb for the last step when spree_core is removed.