Make OFN independent of spree_core

[luisramos0]

What we should change and why (this is tech debt)

Quick summary of the reasons to do this:

• A lot of OFN code is decorating Spree models (from my quick analysis we decorate around 50% of all spree models!), there would be a huge advantage in having the spree core merged with the decorations so we can increase quality, test coverage, etc.
• On top of that spree 2.2, the next upgrade, includes a major refactoring of the spree adjustments logic, OFN has a lot of adaptations on top of the existing adjustments logic for example to include enterprise fees as adjustments. Adapting the OFN code to this new refactoring would be a nightmare. And not upgrading spree blocks us from the main issue which is upgrading rails.
• One huge advantage will be to see all the unnecessary/unused complexity from spree go away, like promotions or stock movements/transfers.

In this epic we remove spree_core dependency and bring to OFN the spree models that we really need on our side. We will need to move a few 1000s of lines of code but the task is relatively simple to execute 🎉

We need to start with a detailed analysis of what decorators exist in OFN and what files from spree_core we will need to bring.

[luisramos0]

This comment was where the initial list of 235 spree_core files that we needed were listed. These files were copied, merged or ignored.

These were the initial stats:
133 are live code classes:

• 74 code classes will have to be copied to OFN
• 40 code classes have to be merged with the existing decorators
• 8 code classes will not be copied but need some adaptations in OFN
• 11 code classes may not need to be copied

102 are test code classes (a lot of these will be ignored):

• 42 specs (and spec helpers) will have to be copied to OFN (or ignored)
• 22 specs have to merged with existing versions on OFN (or ignored)
• 38 are the spree test factories that will have to be copied if they are used in OFN

This is the list of issues and PRs that were created gradually to move the files to OFN:

• mailers [ByeBye Spree] Move Mailers to OFN #5686
• calculators [ByeBye Spree] Move Calculators to OFN #5687
• ControllerHelpers [ByeBye Spree] Move ControllerHelpers to OFN #5688
• model payment and processing [ByeBye Spree] Move Payment model to OFN #5689
• app/models/spree/stock [ByeBye Spree] Move app/models/spree/stock to OFN #5690
• model stock_item 5300 Avoid race conditions in Spree::StockItem #5406
• core/app/models/spree/order/checkout.rb Reset order state to cart in case the stripe SCA authorization step fails #5824
• core/app/models/spree/order_updater.rb and spec Bring Order Updater from spree_core #5758
• most files in core/lib/spree [ByeBye Spree] Move lib/spree to OFN #5734
• models country, zone, zone_member [Bye bye Spree] Bring models country, zone and zone_member from spree_core #5866
• models stock_location and stock_movement [Bye bye Spree] Bring models stock_location and stock_movement from spree_core #5867
• models taxon and taxonomy [Bye bye Spree] Bring models taxon and taxonomy from spree_core #5868
• models image and asset [Bye bye Spree] Bring models image and asset from spree_core #5869
• models app_config and preferences [Bye bye Spree] Bring models app_configuration and preference from spree_core #5870
• models shipping_category, ship_method, shipping_method_category, shipping_rates [Bye bye Spree] Bring models shipping_method, shipping_rates, address and shipping_category from spree_core #5878
• models payment_method, gateway and credit_card [Bye bye Spree] Bring models payment_method, credit_card and gateway from spree_core #5879
• models tax_rate, adjustment, tax_category and calculator [Bye bye Spree] Bring models tax_rate, tax_categories, adjustments and calculator from spree_core #5883
• models variant, product and price, option_value and option_type [Bye bye Spree] Bring models product, variant, price from spree_core #5885
• models order, order_inventory, line_item, tokenized_permission, order_contents [Bye bye Spree] Bring models order, line_item and other related from spree_core  #5887
• last bit of js and css [Bye bye spree] Bring final bits of js and css from spree_core #5928
• basse_controller, base_helper and log entry [Bye bye spree] Bring base_helper and log_entry from spree core #5924
• Spree engine.rb [Bye bye spree] Bring Spree engine.rb from spree core #5929
• models role and ability as well as user extensions [Bye bye spree] Bring classes related to users to OFN #5925
• helpers in core/lib/spree/testing_support [Bye bye Spree] Make OFN independent of spec helpers under core/lib/testing_support #5941
• spec factories [Bye bye Spree] Make OFN independent of all spree spec factories #5943

And this is the list of files remaining:

Some DB default data:
core/db/default/spree/roles.rb COPY
core/db/default/spree/zones.rb MAYBE COPY

I am not sure we need these:
core/app/models/spree/product/scopes.rb MAYBE NO COPY - see product_fitlers, do we use this?
core/spec/models/spree/product/scopes_spec.rb see previous
core/app/models/spree/product_scope/scopes.rb MAYBE NO COPY same as above
core/app/models/spree/variant/scopes.rb MAYBE NO COPY same as above
core/spec/models/spree/variant/scopes_spec.rb see previous

[luisramos0]

oh, this is done.