Make display_on attribute available for managers to change in shipping and payment methods #5493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisramos0
force-pushed
the
display_on_4_managers
branch
from
1d25d25 to
cb0aefd
Compare
luisramos0
changed the title
luisramos0
changed the title
Matt-Yorkley
approved these changes
May 25, 2020
kristinalim
approved these changes
May 26, 2020
|
Hey @luisramos0, This is good to go - the selector now appears for enterprise managers as well, and works as expected. Also, the warning has been included in the en.yml - perfect! Ready to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
Fixes a problem introduced in #5392 where a message is shown to managers but the option was only available to admins. This PR makes the option available to all users of this page.
What should we test?
We dont need to test #5392 again, I think we just need to validate the option shows up for managers as well as admins now.
Release notes
Changelog Category: Added
Make shipping and payment methods option display_on available to managers.