Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v2.9.10 Chop suey #5488

Closed
7 tasks done
kristinalim opened this issue May 22, 2020 · 9 comments
Closed
7 tasks done

Release v2.9.10 Chop suey #5488

kristinalim opened this issue May 22, 2020 · 9 comments
Assignees

Comments

@kristinalim
Copy link
Member

kristinalim commented May 22, 2020

Steps:

The full process is described at https://github.com/openfoodfoundation/openfoodnetwork/wiki/Releasing.

@kristinalim kristinalim self-assigned this May 22, 2020
@RachL RachL self-assigned this May 24, 2020
@RachL RachL added the pr-staged-fr staging.coopcircuits.fr label May 24, 2020
@RachL
Copy link
Contributor

RachL commented May 25, 2020

@kristinalim all good :) https://docs.google.com/document/d/1VATnN9bnV6wKNydZMJbbnGNQVvW8DLH37vnql9fvXaY/edit#

I just noticed we are introducing a text for enterprise managers that is not really accurate, but Luis already made a PR to fix the issue: #5392 (comment)

So basically the text will be wrong during - worse case scenario - 1 week and will affect only managers creating new shipping methods. Maybe it is ok as long as we inform instance managers? Otherwise it might be good to change the text introduced in #5399 before deploying the release.

Thoughts?

@luisramos0
Copy link
Contributor

I think the PR is easy enough to be reviewed and tested today:
#5493

@RachL
Copy link
Contributor

RachL commented May 25, 2020

@kristinalim actually there might be a release blocker in what Luis' is describing here: #5440 (comment)

I will make an issue when I come back online in a few hours, unless someone else already has.

@filipefurtad0
Copy link
Contributor

Here it is:
Switching between shops does not work correctly #5496

@RachL RachL added blocked and removed pr-staged-fr staging.coopcircuits.fr labels May 26, 2020
@luisramos0
Copy link
Contributor

I think the easiest way forward is to create a branch with the release and patch it with both #5501 and #5493
After that we can stage that patch and run some tests to validate it's good to go.
Sounds good?

@RachL
Copy link
Contributor

RachL commented May 27, 2020

@luisramos0 yes!

@luisramos0
Copy link
Contributor

I have created the branch with 2.9.10 + 5501 + 5493 and updated the sempahore link in the description of this issue. It's ready for testing.

@RachL RachL added the pr-staged-fr staging.coopcircuits.fr label May 27, 2020
@filipefurtad0 filipefurtad0 removed the pr-staged-fr staging.coopcircuits.fr label May 27, 2020
@filipefurtad0
Copy link
Contributor

filipefurtad0 commented May 27, 2020

It's good to go @luisramos0 🎉

@luisramos0
Copy link
Contributor

ok, I published it now.
@kristinalim I think this can now be deployed whenever possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants