Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Spree 2.1] Implement strong params in subscriptions controller #5037

Merged
merged 4 commits into from
Mar 25, 2020
Merged

[Spree 2.1] Implement strong params in subscriptions controller #5037

merged 4 commits into from
Mar 25, 2020

Conversation

luisramos0
Copy link
Contributor

What? Why?

Implements #4644 for subscriptions_controller.
This is what was on #4827 plus the last commit to extract things to a service.

What should we test?

More green specs 🎉

@luisramos0 luisramos0 self-assigned this Mar 21, 2020
@luisramos0 luisramos0 mentioned this pull request Mar 21, 2020
Merged
Matt-Yorkley
Matt-Yorkley approved these changes Mar 21, 2020
View reviewed changes
Copy link
Contributor

@Matt-Yorkley Matt-Yorkley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@sauloperez sauloperez merged commit 2c487c2 into openfoodfoundation:3-0-stable Mar 25, 2020
@luisramos0 luisramos0 deleted the strong_params_subs branch March 25, 2020 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sauloperez sauloperez sauloperez approved these changes

@Matt-Yorkley Matt-Yorkley Matt-Yorkley approved these changes

Assignees

@luisramos0 luisramos0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luisramos0 @sauloperez @Matt-Yorkley