[Spree 2.1] Implement Strong Parameters in various controllers #4827

luisramos0 · 2020-02-22T12:56:19Z

What? Why?

#4828 disabled protected_attributes and started to implement strong parameters on some controllers.
This PR continues that task #4644

What should we test?

More green specs with no ForbiddenAttribute error.

app/controllers/spree/admin/products_controller.rb

app/controllers/admin/order_cycles_controller.rb

app/controllers/admin/inventory_items_controller.rb

app/controllers/admin/subscriptions_controller.rb

app/controllers/admin/variant_overrides_controller.rb

app/controllers/spree/admin/payment_methods_controller.rb

app/controllers/spree/admin/payments_controller.rb

app/controllers/spree/admin/resource_controller.rb

app/controllers/spree/admin/taxons_controller.rb

luisramos0 · 2020-02-25T15:36:28Z

ready for review again @Matt-Yorkley

app/controllers/admin/enterprises_controller.rb

app/controllers/spree/admin/resource_controller.rb

app/controllers/spree/admin/taxons_controller.rb

Matt-Yorkley

Awesome 🎉

app/controllers/admin/enterprises_controller.rb

Matt-Yorkley · 2020-02-26T08:30:50Z

You left a byebug in the zones controller commit: a9dae09

app/controllers/spree/admin/zones_controller.rb

This code comes from spree commit openfoodfoundation/spree@fbc2d15

… controllers

luisramos0 · 2020-03-21T20:34:29Z

ok, job done.
I left the most simple cases in this PR, ready for final review (no changes).

And I extracted 7 PRs out of this one, all ready for review:

payment methods [Spree 2.1] Implement strong params in admin payment methods controller #5034
order cycle [Spree 2.1] Implement strong params in admin Order cycles controller #4876
checkout [Spree 2.1] Implement strong params in checkout controller #5035
users [Spree 2.1] Implement strong params in user related controllers #5036
subs [Spree 2.1] Implement strong params in subscriptions controller #5037
products et al [Spree 2.1] Implement strong params in products, variants, variant_overrides and resource controllers #5038
enterprises and customers [Spree 2.1] Implement strong params in enterprises, enterprise_groups, enterprise_roles, customers and customer_details controllers #5039

luisramos0 changed the base branch from master to 3-0-stable February 22, 2020 12:56

luisramos0 self-assigned this Feb 22, 2020

luisramos0 changed the title ~~Strong params~~ WIP Handle strong params WITHOUT the protected_attributes gem Feb 22, 2020

luisramos0 force-pushed the strong_params branch 2 times, most recently from db397d1 to 65b812a Compare February 22, 2020 19:17

luisramos0 changed the title ~~WIP Handle strong params WITHOUT the protected_attributes gem~~ [Spree 2.1] Implement Strong Parameters in some controllers Feb 22, 2020

This was referenced Feb 22, 2020

WIP Add strong params permit to subs controller and adapt to new mass_assignemnt logic in rails 4 #4822

Closed

[Spree 2.1] Implement Strong Parameters #4644

Closed

luisramos0 force-pushed the strong_params branch from 83deb8a to fbe732c Compare February 23, 2020 13:49

Matt-Yorkley reviewed Feb 23, 2020

View reviewed changes

app/controllers/spree/admin/products_controller.rb Outdated Show resolved Hide resolved

luisramos0 force-pushed the strong_params branch from 1a82fd0 to 8d8895e Compare February 23, 2020 22:05

luisramos0 changed the title ~~[Spree 2.1] Implement Strong Parameters in some controllers~~ [Spree 2.1] Implement Strong Parameters in most controllers Feb 23, 2020