[Defacepocalypse] De-deface product properties index #4074
Conversation
|
I found this last week, it works really well for erb-haml :-O |
There was a problem hiding this comment.
eheh, great to have you back Hugo!!!!
I think the js tag will not be working...
It would be good to also bring from spree and convert to haml the missing partials:
- 'spree/admin/shared/edit_resource_links'
- 'spree/admin/shared/product_sub_menu'
- 'spree/shared/error_messages'
Done! |
HugsDaniel
force-pushed
the
defacepocalypse
branch
from
f14698a to
c83d249
Compare
|
@hugs I can add and edit properties. However, I cannot add them to products afterwards. I don't have a dropdown in And in staging ES with this PR I had this:
|
|
Hey @RachL , how do you add properties to a product ? About the dropdown, I have this in master currently :
No dropdown, just a regular autocomplete. Can you check master ? |
|
😭 I hoped French staging had a recent version of master. So this means the bug was introduce somewhere else... In production the dropdown is still here. So it is really a bug that we will introduce with the new release. About the properties, you can add them in |
|
:-( |
|
@RachL there's no dropdown but there is still autocomplete on the property's name. I'm not sure it's blocked however, since the bug has nothing to do with de-defacing. The HTML is pretty much the same as master, there's just a problem elsewhere with select2 dropdowns. |
|
@HugsDaniel I've put the blocked label because once the dropdown is fixed, I don't know if the fix will have another impact on this PR. I just feel I cannot complete the test. I will see if we squease a fix for the bug or not soon so I can re-test both. |
|
@HugsDaniel I've just staged master as part of the release test and I do have the dropdown... Can you check master again on your side? |
|
I found #1759 that is related to this PR. Maybe something to look at as part of this PR. |
|
@RachL stupid question but the dropdown appears only for non admin users, I guess you tested it with both types ? |
|
I have this in this branch for a non admin user : Seems to be working fine ! |
|
@luisramos0 I tackled #1759 at the same time. @RachL can you test if the dropdown has two arrows on the right, like they have in my screenshot above ? |
|
@HugsDaniel yes I do have the dropdown, but only one arrow:
So I guess you only need to tackle the unsucessful checks? |
|
Rebuild passed on Semaphore, so those build errors are random. So I guess good to go then? |
What? Why?
There's no issue but it's part of #2807
Closes #1759
I imported and de-defaced views from
spree/backend/app/views/spree/admin/product_properties. So now we have two more views :app/views/spree/admin/product_properties/_product_property_fields.html.hamlapp/views/spree/admin/product_properties/index.html.hamlAlso added a
%th.no-borderto fix the weird shift between table headers and input fields.Appart from that, no functional changes done, just bringing code from spree, converting to haml and applying the defaces.
What should we test?
Make sure this page works as before :
Release notes
Changelog Category: Changed
Removed deface from a few parts of the backoffice thus making OFN less entangled with Spree code.