De-deface some admin configuration pages and the general admin layout and menu #4047
Conversation
In admin layout, only adds a div after the body tag.
…entries from layouts/admin to the tabs view
…(in shared/head partial) content type tag
…spree_frontend which is not used in ofn anymore
… the order tabs view
… in admin/order/show which is a view that is not used in ofn anymore, only admin/order/edit is used
…ttings page to keep order. No changes in code, just moving
…ses attribute and it is no longer used
luisramos0
changed the title
luisramos0
changed the title
There was a problem hiding this comment.
I did not look at every line, to be honest. ;-)
Some could say that you added 250 lines of code to OFN that we now need to maintain. But if we maintain Spree code anyway, then you removed 130 lines from Spree+OFN code. 🎉
And the code is better structured and easier to maintain.
|
@luisramos0 One failing spec. |
… element to be there before using it
|
and by that second line of thought, each spree module we remove from our list of dependencies represents thousands of lines of code we remove! |
I change the configurations (cookies, title, terms and conditions...) all went well
The main admin menu is working fine. I tested super admin and manager's views. This is ready to go |
|
I'm wondering why we didn't catch the breaking changes in here.
@RachL Can you remember if you saw the affected parts when testing? |
|
@mkllnk I had a quick look on the page layouts, but I didn't use ALL the pages except the ones listed above. So I may have miss these errors. B. On product, OC and subs pages, the icons are not centered
But these two things do not affect how the pages are working, or am I missing something? |
What? Why?
There's no issue for this but this is part of #2807. In this PR I am de-defacing a few things in the backoffice:
No functional changes done, just bringing code from spree, converting to haml and applying the defaces.
What should we test?
Make sure these pages show all fields and work as before:
The main admin menu has a new order of entries.
The main admin layout was de-defaced, in terms of testing I think a general test of menus, submenus and general page layouts should be enough.
Release notes
Changelog Category: Changed
Removed deface from a few parts of the backoffice thus making OFN less entangled with Spree code.